Conversation
jamaljsr
changed the title
Member
Author
|
This PR is ready for review. I added initial unit tests for the mobx store and actions. There's also some configuration updates included for code linting and tweaking the testing framework. Run |
jamaljsr
requested review from
a team and
guggero
and removed request for
a team
guggero
approved these changes
Apr 14, 2020
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Solid setup! Was able to get everything running locally.
Unusual to see a project starting with >90% of test coverage 😮 👍 great work!
Should we add a Travis run configuration as well? Now that there is a test:ci action to run?
Member
Author
|
@guggero I added a I agree that we should add a Travis build. I can work on that in a separate PR. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just adds the mobx store and some actions to start with. It's WIP for now as I want to add unit tests.